The English present perfect (preterite compuesto) "I have done" is often used in Spanish for the past definite "I did," when the period of time in which the action took place is not specified.
The Spanish Academy gives—
Siempre que he ido á Madrid he visitado el Prado for Whenever I went to Madrid I visited the Prado.
We even find "ayer he hecho esto ó aquello" for "yesterday I did this or that," and this is accounted for by the "nearness" of the period elapsed. Although colloquially this does not sound at all so badly as in English, well-educated Spaniards will take care to avoid it.
The second or bye-form of the imperfect subjunctive may be used also for the conditional mood, as—
Se lo diera si lo tuviese instead of se lo daría, etc.: I should give it to him if I had it.
It is also found (in books, not in conversation) for the compound imperfect indicative, especially after que, as—
Los consejos que le diera (for que le había dado): The advice which I had given him.
In old Spanish, and even now in poetry, we find it used for every one of the compound past tenses.
=General Observations=.